Don Moir
Sometimes when downloading lyrics, everything in VDJ freezes except the audio. Meaning the VDJ UI and video are frozen. This happens when something has gone wrong with lyrics retrieval. It is not difficult to reproduce. Happens depending on song and what information is available for that song I guess. When something has gone wrong, I get html text and not normal LRC text. for example:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xmlns:og="http://opengraphprotocol.org/schema/" xmlns:fb="http://ogp.me/ns/fb#">
<head><title>
Hank Williams I'm So Lonesome I Could Cry Lyrics Lrc ... etc,
The actual text is full html but just pasted that much in. It can get to a point where it is easy to crash VDJ depending on circumstances. Additional note about the freezing. Are you actually doing the lyrics retrieval in the main thread and when it gets hung up everything freezes? Maybe also a clue why other people report freezing under different circumstances. In any case, surely the lyrics retrieval should not be hanging anything up every if it messes up. I would think it would be in some independent thread.
Seems fairly easy to reproduce this but here is one song that it happens every time for me. So keep everything as is include filename and then try and download the lyrics. Have some video running to easily see the freeze. Once it gets past whatever it is doing, the UI and video becomes responsive again. Of course if you then save this html text as the lyrics, then that is all messed up as well.
http://www.tellyvisuals.com/LyricsTestSample.zip
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xmlns:og="http://opengraphprotocol.org/schema/" xmlns:fb="http://ogp.me/ns/fb#">
<head><title>
Hank Williams I'm So Lonesome I Could Cry Lyrics Lrc ... etc,
The actual text is full html but just pasted that much in. It can get to a point where it is easy to crash VDJ depending on circumstances. Additional note about the freezing. Are you actually doing the lyrics retrieval in the main thread and when it gets hung up everything freezes? Maybe also a clue why other people report freezing under different circumstances. In any case, surely the lyrics retrieval should not be hanging anything up every if it messes up. I would think it would be in some independent thread.
Seems fairly easy to reproduce this but here is one song that it happens every time for me. So keep everything as is include filename and then try and download the lyrics. Have some video running to easily see the freeze. Once it gets past whatever it is doing, the UI and video becomes responsive again. Of course if you then save this html text as the lyrics, then that is all messed up as well.
http://www.tellyvisuals.com/LyricsTestSample.zip
Mensajes Sun 21 Jan 18 @ 5:36 pm
Adion
Thanks for reporting, will be fixed.
Downloading is asynchronous, but handling of the returned data became inefficient with the unexpected data, causing the slow-down.
Downloading is asynchronous, but handling of the returned data became inefficient with the unexpected data, causing the slow-down.
Mensajes Mon 22 Jan 18 @ 9:44 pm